Fix the set_phys ioctl binding and add physical path support to the VirtualDeviceBuilder #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-hiner
approved these changes
Jul 26, 2023
Collaborator
jeff-hiner
left a comment
jeff-hiner
left a comment
There was a problem hiding this comment.
Good catch. Yeah, probably a good half of the ioctls in Linux are weird in some way for legacy reasons.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the ui_set_phys ioctl binding in sys.rs and adds a with_phys method to VirtualDeviceBuilder in uinput.rs.
The ioctl for set_phys is regrettably a bit weird. Whilst it expects to receive a pointer to a c string, it doesn't want the length of this string, but rather the size of the pointer itself.
A simple pointer cast is the cleanest workaround for this issue that I know of.
Setting the physical path of a virtual device is a pretty niche application, but can be extremely useful.