-
-
Notifications
You must be signed in to change notification settings - Fork 20
Clean testing on a clean up test corpus #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…miss the closing of the balanced comment. Fixes elm-tooling#78
|
For whatever reason, the env var didn't pick up the default. For the new testing to pass we need to fix the path to the test corpus repo in repo vars.
Alternatively I can hard-code the path and then we fix it in another PR if you agree to move the data over to |
…e memory exhaustion. Ensure VEC_POP always has valid indent buffer to work with.
|
Hey! Is there anything else you expect from me on this one? |
|
Looking at this, I don't really like the test changes. If you really would want the tests to not run against head, just change the old script to checkout the tags instead of head? |
Resolved all real failures in the test. A few real failures were linked to multiline string parsing: after replacing the regex with a new token in the scanner, all parses are correct.
While at it, also resolved the bug with nesting block comments. Closes #78
About 50 files were elm 0.18 or syntax errors. Checked each one individually on Elm 0.19 compiler. Blacklisted those files in
expected_fails.txt. The existingparse-examples-fullwill probably report 51 error since it doesn't know about the blacklist.Finally, I cleaned up the test corpus: instead of downloading each repo and risking that something changes, I moved all
.elmfiles and licenses into a clean repo. This gives us a stable test inputs. I've added a new scriptparse-test-corpusthat works on that corpus, and the corresponding workflow actiontest-on-test-corpus.yml.If you agree with that new workflow, it obsoletes a bunch of test scripts that I can delete in another PR.
The test files are presently in my GitHub account, but I'd like to move that repo over to
elm-toolingif you're ok with that.