Allow custom AAD to be provided to message encryptor #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes sense to allow this flexibility! Worth noting for posterity that while customizing the AAD doesn't provide any greater sense of cryptographic strength, it does provide another avenue of authenticating the decryption request and this change exposes that ability to the user. |
Member
Author
|
Thank you @houllette, precisely that. We want to encrypt metadata into Livebooks, and we were planning to pass the notebook itself as AAD. |
|
Awesome! You shouldn't have a problem with doing that provided the entire Livebook your passing in is smaller than 2.31 exabytes 🙂 (since AAD has a 264 bit maximum) |
Contributor
|
+1, no concerns with supporting custom AAD! |
Member
Author
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@voltone @GriffinMB do you see any concerns with allowing a custom AAD when additional content needs to be added to the integrity?
RFC 7518 specifies empty and we already defaulted to A128GCM, which is preserved, but I wonder if you have any concerns.
Thank you!