docs: add arity to macro reference of def/2 and defmodule/2 #13882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
I am fine with this change but I would like another Elixir committer to double check if we want to introduce those with arity when we first talk about them. Most of time, users will initially see them as keywords. If you agree, feel free to merge (or close otherwise).
whatyouhide
reviewed
Oct 6, 2024
Co-authored-by: Andrea Leopardi <[email protected]>
|
Since there is no consensus, I went with the smallest change, and we can revisit it altogether later. :) |
|
💚 💙 💜 💛 ❤️ |
Sounds good 👍 will try to come up with a proposal for further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.