fix: jna os info on linux/macos #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <[email protected]>
sgammon
added
bug
sgammon
added
platform:macos
darvld
reviewed
Jun 8, 2024
Comment on lines
+174
to
+176
| SHARED -> if (it.registerJni) { /* Dynamic JNI libraries use JNI to load. */ } else { | ||
| nativeLibraries.addDynamicNonJniLibrary(it.name) | ||
| } |
There was a problem hiding this comment.
Is there a point to having the empty if branch? why not invert the condition and keep the comment?
There was a problem hiding this comment.
@darvld good point -- should get compiled out since it.registerJni is known at compile time (this is all build time code anyway) but will catch in the next PR. there is going to be logic in that other branch eventually, i think
There was a problem hiding this comment.
I agree that the compiler will optimize it out, I was just checking if you had forgotten to add some logic there 👍
darvld
approved these changes
Jun 8, 2024
sgammon
force-pushed
the
fix/jna-os-info
branch
2 times, most recently
from
b18911c to
61a8999
Compare
Closed
- fix: jna/oshi reflection and proxy metadata - fix: no stacktrace for host-side error causes in native mode - chore: cpu test script - chore: update `graalvm` module pin / detekt baseline Fixes and closes #990 Signed-off-by: Sam Gammon <[email protected]>
This was referenced Jun 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds on top of #988 with a better suite of fixes on both macOS and Linux for OS info obtain via OSHI/JNA. Fixes and closes #990.
Changelog
graalvmmodule pin / detekt baseline