Skip to content

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Sep 18, 2025

Ready for review Powered by Pull Request Badge

Summary

More fixes for Elide's use under locales other than GVM's default of en_US. Fixes for warnings experienced in some Linux contexts related to terminal info gathering.

Changelog

fix: make jline always use english level name for logging
fix: warn on unsupported localization settings at startup
fix: force default locale when unsupported locale is used
fix: warnings for jline terminal detection
fix: it's `en_GB`, not `en-GB`
chore: add active locale output to `elide info`

fix: make jline always use english level name for logging
fix: warn on unsupported localization settings at startup
fix: force default locale when unsupported locale is used
fix: warnings for jline terminal detection
fix: it's `en_GB`, not `en-GB`
chore: add active locale output to `elide info`

Fixes: #1650
Fixes: #1639
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon added this to the Release R18: Beta milestone Sep 18, 2025
@sgammon sgammon requested a review from a team September 18, 2025 01:38
@sgammon sgammon self-assigned this Sep 18, 2025
@sgammon sgammon added this to Elide Sep 18, 2025
@sgammon sgammon added bug Something isn't working module:cli CLI module issues and features P0 labels Sep 18, 2025
@sgammon sgammon moved this to In Progress in Elide Sep 18, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.97%. Comparing base (4a274e4) to head (b0ef4be).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/cli/src/main/kotlin/elide/tool/cli/main.kt 0.00% 17 Missing ⚠️
...ain/kotlin/elide/tool/feature/RelocalizeLogging.kt 0.00% 3 Missing ⚠️
.../kotlin/elide/tool/cli/cmd/info/ToolInfoCommand.kt 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
- Coverage   39.98%   39.97%   -0.01%     
==========================================
  Files         783      784       +1     
  Lines       37433    37459      +26     
  Branches     5295     5300       +5     
==========================================
+ Hits        14969    14976       +7     
- Misses      20675    20691      +16     
- Partials     1789     1792       +3     
Flag Coverage Δ
jvm 39.97% <18.51%> (-0.01%) ⬇️
lib 39.97% <18.51%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../kotlin/elide/tool/cli/cmd/info/ToolInfoCommand.kt 72.22% <71.42%> (-0.51%) ⬇️
...ain/kotlin/elide/tool/feature/RelocalizeLogging.kt 0.00% <0.00%> (ø)
...ackages/cli/src/main/kotlin/elide/tool/cli/main.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a274e4...b0ef4be. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon merged commit be553b1 into main Sep 18, 2025
28 of 29 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Elide Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working module:cli CLI module issues and features P0

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Warnings about Linux terminals Exception when running on any usage

3 participants