-
Notifications
You must be signed in to change notification settings - Fork 31
feat: S3 support #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: S3 support #1611
Conversation
ea40001 to
3f423f3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
=======================================
Coverage ? 39.98%
=======================================
Files ? 783
Lines ? 37433
Branches ? 5295
=======================================
Hits ? 14969
Misses ? 20675
Partials ? 1789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Nathan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, especially on tests 👍
| private val jsObj: Map<String, Any> = mapOf( | ||
| "write" to ProxyExecutable { args -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good, but even better:
private val jsObj: Map<String, Any> = buildMap {
this["write"] = ProxyExecutable { ... }
}using buildMap allows you to establish a new block, which is more flexible than an arg suite
anyway you don't need to update this particular code, it's just good to know for later 👍
Summary
Added S3 support to javascript environments for S3 and other compatible APIs
Changelog