Skip to content

Conversation

@natehak
Copy link
Contributor

@natehak natehak commented Aug 15, 2025

Ready for review Powered by Pull Request Badge

Summary

Added S3 support to javascript environments for S3 and other compatible APIs

Changelog

  • fix(dev): S3 support

@natehak natehak requested a review from sgammon as a code owner August 15, 2025 23:17
@natehak natehak marked this pull request as draft August 15, 2025 23:17
@sgammon sgammon requested a review from a team August 17, 2025 17:57
@sgammon sgammon added feature Large PRs or issues with full-blown features lang:javascript Issues relating to JavaScript labels Aug 17, 2025
@sgammon sgammon added this to Elide Aug 17, 2025
@sgammon sgammon added this to the Release R18: Beta milestone Aug 17, 2025
@sgammon sgammon moved this to In Progress in Elide Aug 17, 2025
@natehak natehak force-pushed the feat/s3 branch 3 times, most recently from ea40001 to 3f423f3 Compare August 19, 2025 23:01
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 44 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@4823c06). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../kotlin/elide/runtime/intrinsics/js/s3/S3Module.kt 86.77% 19 Missing and 13 partials ⚠️
...c/main/kotlin/elide/runtime/intrinsics/js/s3/S3.kt 45.45% 4 Missing and 8 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1611   +/-   ##
=======================================
  Coverage        ?   39.98%           
=======================================
  Files           ?      783           
  Lines           ?    37433           
  Branches        ?     5295           
=======================================
  Hits            ?    14969           
  Misses          ?    20675           
  Partials        ?     1789           
Flag Coverage Δ
jvm 39.98% <83.33%> (?)
lib 39.98% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/main/kotlin/elide/runtime/intrinsics/js/s3/S3.kt 45.45% <45.45%> (ø)
.../kotlin/elide/runtime/intrinsics/js/s3/S3Module.kt 86.77% <86.77%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4823c06...79ecfd9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@natehak natehak marked this pull request as ready for review August 20, 2025 15:58
Signed-off-by: Nathan <[email protected]>
Copy link
Member

@sgammon sgammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, especially on tests 👍

Comment on lines +149 to +150
private val jsObj: Map<String, Any> = mapOf(
"write" to ProxyExecutable { args ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good, but even better:

private val jsObj: Map<String, Any> = buildMap {
  this["write"] = ProxyExecutable { ... }
}

using buildMap allows you to establish a new block, which is more flexible than an arg suite

anyway you don't need to update this particular code, it's just good to know for later 👍

@natehak natehak merged commit 5a2cc4e into elide-dev:main Sep 10, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Elide Sep 10, 2025
@sgammon sgammon mentioned this pull request Sep 21, 2025
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Large PRs or issues with full-blown features lang:javascript Issues relating to JavaScript

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants