Skip to content

feat: add polyfilled fetch support #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2025
Merged

feat: add polyfilled fetch support #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/src/main/kotlin/elide/tool/cli/Elide.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ import elide.tool.io.RuntimeWorkdirManager
NativeEngine.boot(RuntimeWorkdirManager.acquire()) {
listOf(
"elide.js.vm.enableStreams" to "true",
"jdk.httpclient.allowRestrictedHeaders" to "Host,Content-Length", // needed for fetch
"io.netty.allocator.maxOrder" to "3",
"io.netty.serviceThreadPrefix" to "elide-svc",
"io.netty.native.deleteLibAfterLoading" to "true", // reversed bc of bug (actually does not delete)
Expand Down
1 change: 1 addition & 0 deletions packages/graalvm/src/main/kotlin/elide/runtime/core/internals/graalvm/GraalVMEngine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ import org.graalvm.polyglot.HostAccess as PolyglotHostAccess
.allowCreateProcess(true)
.allowHostClassLoading(true)
.allowNativeAccess(true)
.allowHostClassLookup { true }
.engine(engine)

// allow plugins to customize the context on creation
Expand Down
11 changes: 6 additions & 5 deletions packages/graalvm/src/main/kotlin/elide/runtime/plugins/js/JavaScript.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,22 +128,23 @@ import elide.runtime.plugins.js.JavaScriptVersion.*
"js.string-lazy-substrings",
"js.shadow-realm",
"js.zone-rules-based-time-zones",
// Enabled for use by polyfills or for experimental features:
"js.java-package-globals",
"js.graal-builtin",
"js.polyglot-evalfile",
"js.load",
"js.polyglot-builtin",
)

disableOptions(
"js.console",
"js.graal-builtin",
"js.interop-complete-promises",
"js.java-package-globals",
"js.load",
"js.polyglot-evalfile",
"js.print",
"js.regexp-static-result",
"js.scripting",
"js.syntax-extensions",
// Experimental:
"js.operator-overloading",
"js.polyglot-builtin",
)

setOptions(
Expand Down
2 changes: 1 addition & 1 deletion packages/graalvm/src/main/resources/META-INF/elide/embedded/runtime/js/polyfills.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/graalvm/src/test/kotlin/elide/runtime/intrinsics/js/JsGlobalsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,6 @@ private const val ENABLE_SUPPRESSIONS = true
"TextDecoderStream", // not yet implemented
"TextEncoderStream", // not yet implemented
"DOMException", // not yet implemented
).plus(
fetchGlobals
)

// Types which are expected to be provided by JS polyfills.
Expand All @@ -255,6 +253,8 @@ private const val ENABLE_SUPPRESSIONS = true
"TransformStreamDefaultController",
"WritableStreamDefaultController",
"WritableStreamDefaultWriter",
).plus(
fetchGlobals
)).toSortedSet()

// Globals which are expected not to be found host-side.
Expand Down
2 changes: 1 addition & 1 deletion runtime
Open in desktop
Submodule runtime updated 3 files
+1 −0 elide/runtime/js/polyfills/BUILD.bazel
+930 −0 elide/runtime/js/polyfills/fetch.js
+1 −0 elide/runtime/js/polyfills/polyfills.js
Loading