feat(fs): support for copyFile methods
#1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
+ Coverage 54.88% 55.15% +0.27%
==========================================
Files 327 329 +2
Lines 10469 10613 +144
Branches 1736 1775 +39
==========================================
+ Hits 5746 5854 +108
- Misses 4141 4158 +17
- Partials 582 601 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
sgammon
commented
Jul 4, 2024
Comment on lines
-306
to
-307
| checkFileForRead(path) | ||
|
|
There was a problem hiding this comment.
this should eliminate a few syscalls which are HOL blocking and shouldn't be here anyway; if a file is not readable or does not exist, we should surface an exception and fail.
darvld
approved these changes
Jul 4, 2024
sgammon
force-pushed
the
feat/fs-copy-file
branch
2 times, most recently
from
329b2f9 to
9e6ed10
Compare
sgammon
force-pushed
the
feat/fs-copy-file
branch
2 times, most recently
from
e4410bb to
0e96019
Compare
- feat: implement `copyFile` methods in `fs` and `fs/promises` - feat: initial `GuestExecutor` support - feat: guest executor infra - test: add tests for `copyFile` methods - fix: reduce requisite syscalls for file reads - fix: encoding parameter should default to utf8 for `readFile` - fix: bugfixes for behavior in callback behavior for `fs` - fix: support for UTF-32 in `fs` module - fix: js error handling in `fs` module - fix: dependency base for gvm tests with executor - chore: update `runtime` module with new facade exports - chore: unwire direct executor from `fs` - chore: update `graalvm` module pin - chore: wire in guest executors Signed-off-by: Sam Gammon <[email protected]>
sgammon
force-pushed
the
feat/fs-copy-file
branch
from
0e96019 to
6f1868a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds initial support for
copyFilemethods innode:fsandnode:fs/promises.