feat: static jni support for jansi
#1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
added
feature
Closed
- feat: `terminal` package replacing our dependency on `jansi` - fix: polymorphic call in jansi's c layer at `ioctl` - fix: path to native console libs - fix: linkage for jline on linux - chore: update detekt baselines for `graalvm` - chore: wire up native libs for `jansi` - chore: drop resource libraries which are built-in now Signed-off-by: Sam Gammon <[email protected]>
sgammon
force-pushed
the
feat/static-console
branch
from
7c2d047 to
4686121
Compare
darvld
approved these changes
Jun 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 54.62% 54.62%
=======================================
Files 320 320
Lines 10159 10159
Branches 1760 1760
=======================================
Hits 5549 5549
Misses 4078 4078
Partials 532 532
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
This was referenced Jun 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds static JNI support for
jansiandjlinenative, rounding out our current JNI support needs; C code for each library was inlined (and merged, since they happen to duplicate some code). Windows support is stubbed on POSIX systems so that symbols align and are linkable statically.Otherwise, Windows support was preserved.
I did some extra cleanup in this PR: namely, dropping native libraries from resources that are now present statically. It is tested on Linux AMD64 and macOS M-series.
Changelog
terminalpackage replacing our dependency onjansiioctlgraalvmjansi