[!!!][FEATURE] Introduce ClientFactory and clientOptions config
#437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
added
enhancement
|
Code Climate has analyzed commit 6a6c0cc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.5% (0.0% change). View more on Code Climate. |
Pull Request Test Coverage Report for Build 12445934220Details
💛 - Coveralls |
eliashaeussler
force-pushed
the
feature/client-factory
branch
from
b35b6f1 to
d9acb80
Compare
eliashaeussler
force-pushed
the
feature/client-factory
branch
from
d9acb80 to
6a6c0cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
ClientFactory. It is constructed from a new configuration optionclientOptionsand provides a shared Guzzle client for crawlers and parsers. In addition, the existing DI service container usage for crawlers is now extended to parsers by a newContainerFactory. The service container includes the shared Guzzle client as well.