Performance of Sync API is degraded in v1.135.0rc1

[mntu]

The code below in synapse/events/utils.py significantly increases the response time of the Sync API

if config.requester is not None and await self._auth.is_server_admin(
config.requester
):
    config = make_config_for_admin(config)

Why not check if the requester is a Server Admin before calling serialize_event
I tested on my data and it increased the response time of the Sync API by 2 minutes

[pinkc0cb]

I'm experiencing the same issue as well. Hopefully, it will be fixed soon.

[lvphu609]

Why not check if the requester is a Server Admin before calling serialize_event I tested on my data and it increased the response time of the Sync API by 2 minutes

Let me try the workaround you suggested. I'm currently facing the same issue here, and it's significantly affecting the system's performance

[MrRedTA]

The code below in synapse/events/utils.py significantly increases the response time of the Sync API

if config.requester is not None and await self._auth.is_server_admin(
config.requester
):
config = make_config_for_admin(config)
Why not check if the requester is a Server Admin before calling serialize_event I tested on my data and it increased the response time of the Sync API by 2 minutes

Thanks for your raising. Our system has the same issue after upgrade Synapse to v1.135.0rc1. Many users have complained about very slow login to our system.
Hope this issue is fixed ASAP
Thanks so much!

[reivilibre]

Seems like the storage function behind this code path needs a cache on it.

Aside: this computation is trivial (and so expensive storage code paths are not hit) when MAS integration/delegation is enabled, so only legacy auth mode is affected.

[anoadragon453]

Code points to #18238, introduced in v1.135.0rc1 and not yet in a full release.

[anoadragon453]

Should be fixed by #18747.

[mntu]

Should be fixed by #18747.

Thanks for your fixing