Skip to content

run pod with args: properly raise an error if its not ready in time #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
Merged

run pod with args: properly raise an error if its not ready in time #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b715a8
run pod with args: properly raise an error if its not ready in time
gaelgatelement Sep 12, 2025
b770fb3
give 60 seconds to start to pods
gaelgatelement Sep 12, 2025
f2e8100
use state instead of lastState
gaelgatelement Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/730.internal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CI: Raise an error if the pod is not ready when we want to run it.
12 changes: 6 additions & 6 deletions tests/integration/lib/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,24 +148,24 @@ async def run_pod_with_args(kube_client: AsyncClient, generated_data, image_name
start_time = time.time()
now = time.time()
completed = False
while start_time + 30 > now and not completed:
while start_time + 60 > now and not completed:
found_pod = await kube_client.get(Pod, name=pod.metadata.name, namespace=pod.metadata.namespace)
if (
found_pod.status
and found_pod.status.containerStatuses
and found_pod.status.containerStatuses[0].lastState
and found_pod.status.containerStatuses[0].lastState.terminated
and found_pod.status.containerStatuses[0].lastState.terminated.reason == "Completed"
and found_pod.status.containerStatuses[0].state
and found_pod.status.containerStatuses[0].state.terminated
and found_pod.status.containerStatuses[0].state.terminated.reason == "Completed"
):
completed = True
else:
now = time.time()
await asyncio.sleep(1)
else:
if start_time + 30 > now:
if start_time + 60 <= now:
raise RuntimeError(
f"Pod {pod.metadata.name} did not start in time "
f"(failed after {time.time() - now} seconds), "
f"(failed after {now - start_time} seconds), "
f"pod status: {found_pod.status}"
)

Expand Down
Loading