Skip to content

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 9, 2025

Content

Sync string

Motivation and context

Integrate a change for the release announcement of Space.
Handle a key value change.

Screenshots / GIFs

See recorded ones

Tests

  • Nothing particular to test.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 9, 2025 10:26
@bmarty bmarty requested review from ganfra and removed request for a team October 9, 2025 10:26
@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 9, 2025
@ElementBot
Copy link
Collaborator

ElementBot commented Oct 9, 2025

Warnings
⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L7 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L36 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L236 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L241 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L271 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L287 - For locale "cs" (Czech) the following quantities should also be defined: few (e.g. "2 dny"), many (e.g. "10.0 dne"), one (e.g. "1 den")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L298 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L326 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L433 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-da/translations.xml#L286 - For locale "da" (Danish) the following quantity should also be defined: one (e.g. "1 dag")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L7 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L35 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L238 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L242 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L271 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L286 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L298 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L326 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-fr/translations.xml#L432 - For locale "fr" (French) the following quantity should also be defined: many (e.g. "1000000 de jours")

⚠️

libraries/ui-strings/src/main/res/values-hu/translations.xml#L282 - For locale "hu" (Hungarian) the following quantity should also be defined: one (e.g. "A kosár tartalma")

⚠️

libraries/ui-strings/src/main/res/values-nb/translations.xml#L284 - For locale "nb" (Norwegian Bokmål) the following quantity should also be defined: one (e.g. "1 dag")

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L7 - For locale "pt" (Portuguese) the following quantity should also be defined: many

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L35 - For locale "pt" (Portuguese) the following quantity should also be defined: many

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L234 - For locale "pt" (Portuguese) the following quantity should also be defined: many

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L238 - For locale "pt" (Portuguese) the following quantity should also be defined: many

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L267 - For locale "pt" (Portuguese) the following quantity should also be defined: many

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L282 - For locale "pt" (Portuguese) the following quantity should also be defined: many

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L294 - For locale "pt" (Portuguese) the following quantity should also be defined: many

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L321 - For locale "pt" (Portuguese) the following quantity should also be defined: many

⚠️

libraries/ui-strings/src/main/res/values-pt/translations.xml#L427 - For locale "pt" (Portuguese) the following quantity should also be defined: many

Generated by 🚫 dangerJS against 6407d13

Copy link

sonarqubecloud bot commented Oct 9, 2025

Copy link
Contributor

github-actions bot commented Oct 9, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mBfmiS

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.94%. Comparing base (c08590a) to head (6407d13).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5499   +/-   ##
========================================
  Coverage    81.94%   81.94%           
========================================
  Files         2370     2370           
  Lines        67223    67223           
  Branches      8118     8118           
========================================
  Hits         55085    55085           
  Misses        9162     9162           
  Partials      2976     2976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 9, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 9, 2025
@bmarty bmarty merged commit 5852e64 into develop Oct 9, 2025
38 of 41 checks passed
@bmarty bmarty deleted the feature/bma/syncStrings branch October 9, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants