Skip to content

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 9, 2025

Content

Filter out direct room in the leave space screen.

Motivation and context

Closes #5496

Screenshots / GIFs

No expected change

Tests

  • Add a DM to a space (using a client capable of doing this)
  • Attempt to leave the space
  • Observe that the DM is not listed in the room that can be left
  • leave the space
  • observe that the DM has not been left.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 9, 2025 09:43
@bmarty bmarty requested review from jmartinesp and removed request for a team October 9, 2025 09:43
@bmarty bmarty added the PR-Bugfix For bug fix label Oct 9, 2025
Copy link
Contributor

github-actions bot commented Oct 9, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/uvA4vY

Copy link

sonarqubecloud bot commented Oct 9, 2025

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.94%. Comparing base (dbc0c42) to head (1559189).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5498   +/-   ##
========================================
  Coverage    81.94%   81.94%           
========================================
  Files         2371     2371           
  Lines        67240    67240           
  Branches      8117     8117           
========================================
+ Hits         55101    55102    +1     
  Misses        9162     9162           
+ Partials      2977     2976    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 891485d into develop Oct 9, 2025
35 of 36 checks passed
@bmarty bmarty deleted the feature/bma/filterDirectInLeaveSpace branch October 9, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leave space: DMs should not be displayed in the list

2 participants