Skip to content

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 9, 2025

Content

Reduce number of Previews for Avatar.

Motivation and context

It will cover more cases, and it will limit the risk of conflict on screenshot, which happen each time we touch the AvatarSize enum.
Additionnaly it will reveal if there is some unused AvatarSize. And there is one: RoomInviteItem. I will remove in a later PR, I would like to work on AvatarSize but there are pending PRs touching this file, so I wait.

Screenshots / GIFs

No expected change in the app, but number of preview should decrease. It should not impact the code coverage too.

Tests

  • No expected change

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

It will cover more cases, and it will limit the risk of conflict on screenshot, which happen each time we touch AvatarSize.
@bmarty bmarty requested a review from a team as a code owner October 9, 2025 07:59
@bmarty bmarty requested review from ganfra and removed request for a team October 9, 2025 07:59
Copy link
Contributor

github-actions bot commented Oct 9, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Sr4qE1

Copy link

sonarqubecloud bot commented Oct 9, 2025

@bmarty bmarty added the PR-Misc For other changes label Oct 9, 2025
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.94%. Comparing base (dbc0c42) to head (d12ca1f).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5495      +/-   ##
===========================================
- Coverage    81.94%   81.94%   -0.01%     
===========================================
  Files         2371     2371              
  Lines        67240    67223      -17     
  Branches      8117     8117              
===========================================
- Hits         55101    55084      -17     
  Misses        9162     9162              
  Partials      2977     2977              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 33089ff into develop Oct 9, 2025
34 of 35 checks passed
@bmarty bmarty deleted the feature/bma/removeAvatarPreviews branch October 9, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants