-
Notifications
You must be signed in to change notification settings - Fork 306
feature(space): make sure to handle topic properly #5493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
||
@OptIn(ExperimentalMaterial3Api::class) | ||
@Composable | ||
fun TopicViewerBottomSheet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract to its own module (or in a common module) so we can reuse for room topic or other use case?
Should at least be in its own file (but I think the CI is enforcing this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK moving to designsystem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1 to @bmarty 's comment about extracting the topic viewer so we can reuse it, but it's not blocking.
...space/impl/src/main/kotlin/io/element/android/features/space/impl/root/SpaceStateProvider.kt
Show resolved
Hide resolved
fcdc2c4
to
9d05eb8
Compare
...res/space/impl/src/main/kotlin/io/element/android/features/space/impl/root/SpacePresenter.kt
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5493 +/- ##
========================================
Coverage 81.94% 81.95%
========================================
Files 2371 2372 +1
Lines 67240 67298 +58
Branches 8117 8125 +8
========================================
+ Hits 55101 55154 +53
Misses 9162 9162
- Partials 2977 2982 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Content
This PR makes sure :
Motivation and context
Better space support.
Screenshots / GIFs
See recorded ones.
Tests
Tested devices
Checklist