Skip to content

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Oct 8, 2025

Content

This PR makes sure :

  • topic is rendered on 2 lines max in the Space screen
  • topic is rendered in a bottomsheet with clickable links

Motivation and context

Better space support.

Screenshots / GIFs

See recorded ones.

Tests

  • Make sure to have a space with a long topic
  • Open the space on EXA
  • Click on the topic and see the bottomsheet

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added PR-Misc For other changes Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Oct 8, 2025
@ganfra ganfra marked this pull request as ready for review October 8, 2025 20:01
@ganfra ganfra requested a review from a team as a code owner October 8, 2025 20:01
@ganfra ganfra requested review from jmartinesp and removed request for a team October 8, 2025 20:01
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 8, 2025
Copy link
Contributor

github-actions bot commented Oct 8, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tidYco


@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun TopicViewerBottomSheet(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract to its own module (or in a common module) so we can reuse for room topic or other use case?

Should at least be in its own file (but I think the CI is enforcing this)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK moving to designsystem

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 to @bmarty 's comment about extracting the topic viewer so we can reuse it, but it's not blocking.

@ganfra ganfra force-pushed the feature/fga/space_description branch from fcdc2c4 to 9d05eb8 Compare October 9, 2025 07:38
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 9, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 9, 2025
@ganfra ganfra enabled auto-merge October 9, 2025 09:54
Copy link

sonarqubecloud bot commented Oct 9, 2025

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ganfra ganfra merged commit be8455b into develop Oct 9, 2025
28 of 29 checks passed
@ganfra ganfra deleted the feature/fga/space_description branch October 9, 2025 13:39
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 93.90244% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.95%. Comparing base (dbc0c42) to head (59c2a95).
⚠️ Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
...ment/android/features/space/impl/root/SpaceView.kt 86.95% 1 Missing and 2 partials ⚠️
.../designsystem/components/SimpleModalBottomSheet.kt 94.73% 0 Missing and 1 partial ⚠️
.../libraries/matrix/ui/components/SpaceHeaderView.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5493   +/-   ##
========================================
  Coverage    81.94%   81.95%           
========================================
  Files         2371     2372    +1     
  Lines        67240    67298   +58     
  Branches      8117     8125    +8     
========================================
+ Hits         55101    55154   +53     
  Misses        9162     9162           
- Partials      2977     2982    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants