Skip to content

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 24, 2025

Content

Make sure to use the latest apis for space in the sdk :

  • viaParameters to join federated rooms from space
  • space/spaceUpdate api to retrieve the current space data

Motivation and context

Better space support

Screenshots / GIFs

No ui change.

Tests

  • Open a space with rooms created from another homeserver
  • Try to join one of them
  • Should succeed

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added the PR-Misc For other changes label Sep 24, 2025
@ganfra ganfra marked this pull request as ready for review September 24, 2025 12:14
@ganfra ganfra requested a review from a team as a code owner September 24, 2025 12:14
@ganfra ganfra requested review from jmartinesp and removed request for a team September 24, 2025 12:14
Copy link
Contributor

github-actions bot commented Sep 24, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oi1Fw3

@bmarty bmarty added PR-Wip For anything that isn't ready to ship and will be enabled at a later date and removed PR-Misc For other changes labels Sep 24, 2025
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.36%. Comparing base (be3a5c7) to head (6a5098f).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ries/matrix/impl/spaces/SpaceRoomListExtensions.kt 58.33% 5 Missing ⚠️
...o/element/android/features/space/impl/SpaceView.kt 0.00% 1 Missing ⚠️
.../libraries/matrix/impl/spaces/RustSpaceRoomList.kt 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5404      +/-   ##
===========================================
- Coverage    80.37%   80.36%   -0.01%     
===========================================
  Files         2284     2283       -1     
  Lines        63148    63151       +3     
  Branches      7893     7893              
===========================================
- Hits         50755    50753       -2     
- Misses        9478     9482       +4     
- Partials      2915     2916       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ganfra ganfra enabled auto-merge September 24, 2025 13:21
Copy link

@ganfra ganfra merged commit 577f149 into develop Sep 24, 2025
28 of 29 checks passed
@ganfra ganfra deleted the feature/fga/space_list_sdk_api branch September 24, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Wip For anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants