Add a developer option for history sharing on invite #4821
Conversation
|
@richvdh Here are a suggestions for a couple of sections. I think it is important to mention that we share/accept the keys only when room's history visibility is
Share encrypted history with new members
When inviting a user to an encrypted room that has history visibility set to shared, share encrypted history with that user, and accept encrypted history when you are invited to such a room. |
|
Have adjusted the wording and updated the screenshot. |
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4821 +/- ##
========================================
Coverage 80.29% 80.30%
========================================
Files 2152 2152
Lines 57177 57184 +7
Branches 7199 7199
========================================
+ Hits 45913 45919 +6
Misses 8821 8821
- Partials 2443 2444 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| " share encrypted history with that user, and accept encrypted history when you are invited to such a room." + | ||
| "\nRequires an app restart to take effect." + | ||
| "\n\nWARNING: this feature is EXPERIMENTAL and not all security precautions are implemented. Do not enable on" + | ||
| " production accounts.", |
There was a problem hiding this comment.
Maybe split the string at the beginning of the phrase instead?
""\n\nWARNING: this feature is EXPERIMENTAL and not all security precautions are implemented." + "Do not enable on production accounts."
There was a problem hiding this comment.
good idea, thanks. done.
There was a problem hiding this comment.
The "Kotlin way" to do that is something like:
description = """
When inviting a user to an encrypted room that has history visibility set to "shared",
share encrypted history with that user, and accept encrypted history when you are invited to such a room.
Requires an app restart to take effect.
WARNING: this feature is EXPERIMENTAL and not all security precautions are implemented.
Do not enable on production accounts.
""".trimIndent(),but sadly it also adds a line creak between set to "shared", and the next line, and we cannot put all the sentence in a single line as it breaks our line lengh limit.
Ugly alternative is could be
description = """When inviting a user to an encrypted room that has history visibility set to "shared",""" +
" share encrypted history with that user, and accept encrypted history when you are invited to such a room."
.let { firstLine ->
"""
$firstLine
Requires an app restart to take effect.
WARNING: this feature is EXPERIMENTAL and not all security precautions are implemented.
Do not enable on production accounts.
""".trimIndent()
},So... just ignore my comment!
There was a problem hiding this comment.
description = """When inviting a user to an encrypted room that has history visibility set to "shared", """ +
"""
share encrypted history with that user, and accept encrypted history when you are invited to such a room.
Requires an app restart to take effect.
WARNING: this feature is EXPERIMENTAL and not all security precautions are implemented.
Do not enable on production accounts.
""".trimIndent(),works too.
There was a problem hiding this comment.
To be honest, I just did the same as some of the other options already in this file. I agree it's not beautiful, but it's not awful and it is consistent.
Do you want me to update this further, or are you happy with it as-is?
There was a problem hiding this comment.
Going to assume it's ok.
|
5 participants
Content
Adds a new developer flag, enabling our experimental support for MSC4268.
Motivation and context
Part of element-hq/element-meta#2871.
Requires matrix-org/matrix-rust-sdk#5141, so won't build yet.Screenshots / GIFs
Tests
history_visibility: shared(NB that this excludes rooms created on EX), send a message, and invite a user on themultiversetest clientTested devices
Checklist