Reduce margin for RR gutter to 10px #30798
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On small screens and small windows, the 80px beforehand reserved a large amount of screen width, making Element at all difficult to use, especially with threads. Fixes element-hq#30358
github-actions
bot
added
the
Z-Community-PR
|
Looks like this breaks a lot of the screenshot tests. Also, what happens for messages with a lot of read receipts? |
|
Afaik, past a certain amount of read receipts, they get lumped together (e.g. +10), like in this picture: |
Definitely does overlap in certain cases, there's a |
|
It seems like maybe you only tested with Message Bubbles enabled? It might be plausible to scope your change to just applying to that layout if it does work there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using Element Desktop on a small laptop screen, where half the screen is emails and half is Element. Thus, I have a rather narrow and tall layout of my Element Desktop and the 80px right-hand margin for read receipts really hurts there, especially when a thread is open on the sidebar, making stuff hardly readable.
I have been running Element Desktop with a reduced right-hand margin for months now, and have to say, it looks and works way better, and overlay between read receipts and other content does not happen.
This is the same as issue #30358 which also has a nice screenshot.
Fixes #30358
Checklist
- [ ] Tests written for new code (and old code if feasible).- [ ] New or updatedpublic/exportedsymbols have accurate TSDoc documentation.