Skip to content

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 1, 2025

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@hughns hughns added the T-Task Tasks for the team like planning label Sep 1, 2025
@hughns
Copy link
Member Author

hughns commented Sep 1, 2025

I suggest that the SonarCloud quality requirement be overruled.

Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hughns hughns enabled auto-merge September 5, 2025 15:09
@hughns
Copy link
Member Author

hughns commented Sep 8, 2025

I think this will need some override to allow the merge to go through.

@t3chguy
Copy link
Member

t3chguy commented Sep 8, 2025

We tend to follow the sonarcloud coverage gate as it offers an excuse for areas of code get coverage where they didn't have it before. If you want an exception it might warrant joining one of the weekly calls to discuss it.

@hughns
Copy link
Member Author

hughns commented Sep 8, 2025

What has changed is correctly spelling mistakes in some variable names. That the original code didn't have coverage for these lines is unfortunate.

I only happened to come across the spelling mistakes whilst working on something completely different. I don't have the bandwidth to add tests.

@hughns hughns closed this Sep 8, 2025
auto-merge was automatically disabled September 8, 2025 08:44

Pull request was closed

@t3chguy
Copy link
Member

t3chguy commented Sep 8, 2025

Sorry but unfortunately we don't have a way to bypass the coverage gate without force merging which then means skipping a bunch of CI & tests which only run on the merge queue, it is being worked on in #30630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants