Threads panel immediately re-opens

[andybalaam]

Steps to reproduce

1. In a room with several threads, with the thread panel open
2. Click the X in the top right of the thread panel

Outcome

What did you expect?

The thread panel should disappear.

What happened instead?

The thread panel disappears and then immediately re-appears:

[Note: I have tried with both with and without Rich Text Editor enabled in labs.]

Operating system

Ubuntu 22.04

Browser information

Firefox 106.0.2

URL for webapp

https://develop.element.io

Application version

Element version: 8f8a9e1-react-18c03daa865d-js-ba6a001d677f Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes

[andybalaam]

When I switch to another room and back, the behaviour stops, and the thread panel can be dismissed successfully.

[daniellekirkwood]

Occasional and Minor make this a P3 for us, but we'll look into it and see if it can be reproduced etc.

👀 @gsouquet

[germain-gg]

Me and @andybalaam did investigate this a bit more together this morning as he could reproduce it!

All the RightPanelStore code seems to be doing what it needs to do. However, Andy managed to get in a state where https://github.com/matrix-org/matrix-react-sdk/blob/6c556cb88c73902f6345fddc24c3f6d2834d1680/src/components/structures/RoomView.tsx#L621 is executed when closed...

We lost track of the problem after that

[robintown]

For me, what triggers this is opening a thread from a desktop notification.

[andybalaam]

Yes, not every time I get a notification, but it does seem like this is caused by desktop notifications

[andybalaam]

I am getting this again today, again triggered by clicking a desktop notification.