When publishing a threepid to an IS, if you click 'continue' before clicking the link in your email, we delete your threepid from the HS.

[lampholder]

Tested using:

riot.im/develop
the test homeserver andrew spun up
vector.im as the IS

[jryans]

Yes, delete from the HS is indeed the first step we take:

1. Delete from HS
2. Trigger email verification
3. User hopefully verifies email link and presses continue
4. Adjust discovery status

So, we could delay the delete step to avoid this... but rather than doing that, it would be a lot better to use the "re-add with different bind setting" flow from MSC2229.

At the moment though, MSC2229 work is deferred to phase 2.

If this issue is phase 1, should we try only re-ordering the delete (which will add complexity to Riot) or pull MSC2229 into phase 1?

[jryans]

Ah well, @anoadragon453 went ahead and implemented MSC2229 in Synapse just now... so I guess it's "basically free" to pull into phase 1 now, as clients can choose to use it.

[jryans]

Let's do some technical version of:

• checking whether you've already clicked the link in the background, or...
• keep a continue button on screen until you submit it successfully

[jryans]

We are planning to address through an upcoming MSC, so putting this on hold until we have issues to implement the client version of that work.