Upgrade to Electron 6 #10473
Description
Electron 6 recently became the new stable release.
I made a branch to check it out with Riot, but currently it seems to crash immediately on start at least for macOS:
Thread 0:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 libCGInterfaces.dylib 0x00007fff48ecf477 Init_CGInterfaces + 7
1 com.apple.vImage 0x00007fff48ee64db InitCGInterfaces + 539
2 libdispatch.dylib 0x00007fff78a2d63d _dispatch_client_callout + 8
3 libdispatch.dylib 0x00007fff78a2ed4b _dispatch_once_callout + 20
4 com.apple.vImage 0x00007fff48ee62b0 LoadCGInterfaces + 48
5 com.apple.vImage 0x00007fff48ee59e8 vImageConverter_CreateWithColorSyncCodeFragment + 72
6 com.apple.CoreGraphics 0x00007fff4cf3c2d3 CGvImageConverterInitializeShared + 516
7 com.apple.CoreGraphics 0x00007fff4cf3bac7 CGvImageConverterCacheGetRetained + 877
8 com.apple.CoreGraphics 0x00007fff4cf3b714 CGCMSConverterCreateCachedCGvImageConverter + 76
9 com.apple.CoreGraphics 0x00007fff4cf3b624 convert_using_vImageConverter + 393
10 com.apple.CoreGraphics 0x00007fff4cf3b472 convert_icc + 46
11 com.apple.CoreGraphics 0x00007fff4cf3b42f CGCMSConverterConvert + 113
12 com.apple.CoreGraphics 0x00007fff4cf3b32b CGCMSConverterConvertColorComponents + 598
13 com.apple.CoreGraphics 0x00007fff4cf39c0a CGColorTransformConvertColorComponents + 573
14 com.apple.CoreGraphics 0x00007fff4cf492e0 ripc_GetColor + 1596
15 com.apple.CoreGraphics 0x00007fff4cf48325 ripc_Render + 156
16 com.apple.CoreGraphics 0x00007fff4cf453e3 ripc_DrawRects + 354
17 com.apple.CoreGraphics 0x00007fff4cf451f2 CGContextFillRects + 96
18 com.apple.CoreGraphics 0x00007fff4cf4518b CGContextFillRect + 105
19 com.apple.coreui 0x00007fff61217590 -[CUIShapeEffectStack newColorByProcessingColor:] + 470
20 com.apple.coreui 0x00007fff611ef9e2 CUICoreThemeRenderer::CopyCustomColorCore(__CFString const*, __CFDictionary const*) const + 574
21 com.apple.coreui 0x00007fff611ef768 CUICopyCustomColorWithOptions + 236
22 com.apple.AppKit 0x00007fff4a10826c __44-[NSAppearance _copyCustomCGColor:withTint:]_block_invoke + 24
23 com.apple.AppKit 0x00007fff4a12d773 -[NSCompositeAppearance _callCoreUIWithBlock:options:] + 363
24 com.apple.AppKit 0x00007fff4a108201 -[NSAppearance _copyCustomCGColor:withTint:] + 221
25 com.apple.AppKit 0x00007fff4a1080ec -[NSAppearance _customColor:withTint:] + 20
26 com.apple.AppKit 0x00007fff4a2f0bca -[NSDynamicModifiedColor resolvedColor] + 197
27 com.apple.AppKit 0x00007fff4a2f07ea -[NSDynamicNamedColor colorUsingColorSpace:] + 30
28 com.apple.AppKit 0x00007fff4a2f0830 -[NSDynamicNamedColor colorUsingColorSpace:] + 100
29 com.github.Electron.framework 0x000000010d40b1ad 0x10b632000 + 31297965
30 com.github.Electron.framework 0x000000010d40aab9 0x10b632000 + 31296185
31 com.github.Electron.framework 0x000000010d40a729 0x10b632000 + 31295273
32 com.github.Electron.framework 0x000000010d40a602 0x10b632000 + 31294978
33 com.github.Electron.framework 0x000000010ce98d73 0x10b632000 + 25587059
34 com.github.Electron.framework 0x000000010d2eab97 0x10b632000 + 30116759
35 com.github.Electron.framework 0x000000010ce97ec6 0x10b632000 + 25583302
36 com.github.Electron.framework 0x000000010ce9aae2 0x10b632000 + 25594594
37 com.github.Electron.framework 0x000000010ce96496 0x10b632000 + 25576598
38 com.github.Electron.framework 0x000000010cd6b185 0x10b632000 + 24351109
39 com.github.Electron.framework 0x000000010cd6ad71 0x10b632000 + 24350065
40 com.github.Electron.framework 0x000000010f0fd670 0x10b632000 + 61650544
41 com.github.Electron.framework 0x000000010bff7ab4 0x10b632000 + 10246836
42 com.github.Electron.framework 0x000000010b635014 AtomMain + 84
43 im.riot.app 0x000000010b5fca10 0x10b5fb000 + 6672
44 libdyld.dylib 0x00007fff78a7a3d5 start + 1
My branch also upgrades electron-builder, which does mention some signing and sandboxing changes in the release notes. If upgrade only Electron and leave electron-builder as is, we still get a crash with:
Thread 0:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 libobjc.A.dylib 0x00007fff772a052e cache_t::reallocate(unsigned int, unsigned int) + 58
1 libobjc.A.dylib 0x00007fff7729fd0b cache_fill + 195
2 libobjc.A.dylib 0x00007fff7729fa03 lookUpImpOrForward + 1111
3 libobjc.A.dylib 0x00007fff7729f114 _objc_msgSend_uncached + 68
4 com.apple.AppKit 0x00007fff4a1086b9 +[NSColor colorWithColorSpace:components:count:] + 29
5 com.apple.AppKit 0x00007fff4a186892 +[NSColor colorWithSRGBRed:green:blue:alpha:] + 106
6 com.apple.AppKit 0x00007fff4a14b93a __36-[NSDynamicSystemColor recacheColor]_block_invoke + 56
7 com.apple.AppKit 0x00007fff4a14b869 +[NSAppearance _performWithCurrentAppearance:usingBlock:] + 84
8 com.apple.AppKit 0x00007fff4a14b77a -[NSDynamicSystemColor recacheColor] + 305
9 com.apple.AppKit 0x00007fff4a14b526 -[NSDynamicSystemColor initWithSelector:tintedWithColor:] + 120
10 com.apple.AppKit 0x00007fff4a18674c +[NSColor controlAccentBlueColor] + 80
11 com.apple.AppKit 0x00007fff4a1866f2 _NSColorBaseUserHighlightColor + 104
12 com.apple.AppKit 0x00007fff4a2dd7d7 +[NSDynamicSystemColor alternateSelectedControlColor] + 28
13 com.apple.AppKit 0x00007fff4a14b93a __36-[NSDynamicSystemColor recacheColor]_block_invoke + 56
14 com.apple.AppKit 0x00007fff4a14b869 +[NSAppearance _performWithCurrentAppearance:usingBlock:] + 84
15 com.apple.AppKit 0x00007fff4a14b77a -[NSDynamicSystemColor recacheColor] + 305
16 com.apple.AppKit 0x00007fff4a14b526 -[NSDynamicSystemColor initWithSelector:tintedWithColor:] + 120
17 com.apple.AppKit 0x00007fff4a2dd711 +[NSColor alternateSelectedControlColor] + 80
18 com.github.Electron.framework 0x000000010aef0ab1 0x109118000 + 31296177
19 com.github.Electron.framework 0x000000010aef0729 0x109118000 + 31295273
20 com.github.Electron.framework 0x000000010aef0602 0x109118000 + 31294978
21 com.github.Electron.framework 0x000000010a97ed73 0x109118000 + 25587059
22 com.github.Electron.framework 0x000000010add0b97 0x109118000 + 30116759
23 com.github.Electron.framework 0x000000010a97dec6 0x109118000 + 25583302
24 com.github.Electron.framework 0x000000010a980ae2 0x109118000 + 25594594
25 com.github.Electron.framework 0x000000010a97c496 0x109118000 + 25576598
26 com.github.Electron.framework 0x000000010a851185 0x109118000 + 24351109
27 com.github.Electron.framework 0x000000010a850d71 0x109118000 + 24350065
28 com.github.Electron.framework 0x000000010cbe3670 0x109118000 + 61650544
29 com.github.Electron.framework 0x0000000109addab4 0x109118000 + 10246836
30 com.github.Electron.framework 0x000000010911b014 AtomMain + 84
31 im.riot.app 0x0000000105d7ea10 0x105d7d000 + 6672
32 libdyld.dylib 0x00007fff78a7a3d5 start + 1
Seems possibly related to extra helper apps in Electron 6 that need electron-builder changes.