Presence: fix live updates on Home & DM list #6145
Conversation
aringenbach
requested review from
a team,
Anderas and
pixlwave
and removed request for
a team
| { | ||
| // Observe contact presence change | ||
| MXWeakify(self); | ||
| mxDirectUserPresenceObserver = [[NSNotificationCenter defaultCenter] addObserverForName:kMXKContactManagerMatrixUserPresenceChangeNotification object:nil queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *notif) { |
There was a problem hiding this comment.
Would it make sense to pass the directUserId in as the object to reduce the number of times this block will get called? As a bonus, if the ID is nil, the observer wouldn't even need to be created.
There was a problem hiding this comment.
Unfortunately this doesn't seem to work I suppose it has to be the same object rather than two objects that happen to be equal.
There was a problem hiding this comment.
Ah that's a shame, but also seems obvious now you mention it 🤦♂️
There was a problem hiding this comment.
Yeah, fundamentally I'd say using the existing notification system seems like the right thing from my perspective.
As a potential alternative for the cell having some logic, would it make sense to extract the listener logic into an object owned by the presence view? It could be more reusable that way and work automatically if the indicator is added elsewhere in the future.
Yeah I suppose this makes sense and would avoid some code repetition as well. |
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kbz5vG |
3 participants
Fixes #6144
Open to discussion around this solution :)
Advantages:
Drawback:
The other solution would require a few changes on both application and SDK, including :
directUserPresenceonMXRoomSummaryMOso the fetchers can trigger room list updates accordingly