If you reply to a redaction, the redacted text still appears

[giomfo]

Steps to reproduce

• Steps to reproduce
• Send a message
• Reply to that message
• Redact the original message
• The redacted text is displayed, presumably because it's contained in the reply as fallback text

Screenshot:

Note:

• The behavior is correct on Element-Web
• Issue reproduced in Element-Android

Outcome

Element-ios would not display this text, even though the client has access to it.

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

[giomfo]

@anoadragon453 this issue is reproduced in Element-iOS and Element-Android

The redacted event is displayed in the "reply to" bubble even after a clear cache, which means the server is still provided the redacted event to the client don't you think so?

I'm surprised because we don't reproduce the issue on Element-web (You observed it, but it disappeared ) I think the web client handles the reply to differently, it doesn't request the event to the server if the related event is available locally...

Can you please confirm this is a synapse issue ? maybe it is already known

[anoadragon453]

@giomfo clients include the replied-to text in the reply itself as a fallback for clients which don't support replies, which is likely where the text is coming from.

[giomfo]

thx you're right
the received event has the reply to content in the body/formatted_body
the mobile clients should ignored this information when the related event has been redacted

[giomfo]

@daniellekirkwood About this point, I think we should plan to remove the implementation of this fallback on the reply to events.
If I'm correct, the 'fallback" was introduced to display correctly the reply-to event in the applications which don't support reply-to feature...

All platforms are concerned (ios, android, web), let me know if you need more details

[daniellekirkwood]

Yes, I believe that if a message has been redacted it should be removed (replies included).

[manuroe]

Product question: does it worth to keep the "reply to" feature now that we have threads?
Removing the "reply to" will fix this bug.

[daniellekirkwood]

Product question: does it worth to keep the "reply to" feature now that we have threads? Removing the "reply to" will fix this bug.

Thanks, @manuroe. Yes, for now we'll be keeping "reply to". Threads needs to be a lot more mature before we consider removing replies - though I have an assumption that both will be important and used differently (we're using posthog to see)

[jakewb-b]

@daniellekirkwood - sorry for jumping in on this, was just talking to Giom about it as it came up with Dinum.

When you say:

Yes, I believe that if a message has been redacted it should be removed (replies included).

Can I just confirm that you mean the message should be redacted from all places it appears, replies included - not that replies to the message should also be redacted?

If so, I think everyone is aligned that the implementation on web, where it shows 'message deleted' in the quoted portion of the reply, is correct.

Notably there is a similar discrepancy with replying to a message that is later edited. On web the edited message also changes in the reply, whereas on iOS it does not. Either behaviour has pros and cons, but I think to be consistent with the deletion behaviour, we should also take web as correct here, and align mobile with it.

And, I think we're all aligned that fixing this by removing the reply button is not the way forward at least until we have a lot more evidence that threads can replace replies altogether.