Skip to content

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Jan 20, 2023

@yostyle yostyle requested a review from Florian14 January 20, 2023 20:31
@Florian14 Florian14 marked this pull request as ready for review January 24, 2023 10:43
@Florian14 Florian14 requested review from a team and mnaturel and removed request for a team and Florian14 January 24, 2023 10:45
@Florian14 Florian14 changed the title Draft MSC3912 Implement MSC3912 to delete server side all the data of a deleted voice broadcast Jan 24, 2023
@Florian14 Florian14 added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jan 24, 2023
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have just added small comments and questions.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further remarks.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.0% 15.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit c802e2d into develop Jan 25, 2023
@bmarty bmarty deleted the yostyle/msc3912 branch January 25, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants