Skip to content

Conversation

kegsay
Copy link
Contributor

@kegsay kegsay commented Aug 13, 2025

To pull in #3630

Also pulls in a bunch of bug fixes on v12 rooms, which testing did not catch.

FAILURE: #655: Server rejects invalid JSON in a version 6 room is an expected fail now.

@kegsay kegsay requested a review from a team as a code owner August 13, 2025 09:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.32%. Comparing base (0945374) to head (ce84c99).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
roomserver/internal/perform/perform_invite.go 40.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (62.50%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3632      +/-   ##
==========================================
- Coverage   49.32%   49.32%   -0.01%     
==========================================
  Files         524      524              
  Lines       60125    60133       +8     
==========================================
  Hits        29659    29659              
- Misses      26961    26967       +6     
- Partials     3505     3507       +2     
Flag Coverage Δ
unittests 49.32% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neilalexander
Copy link
Contributor

I just got an email notification that matrix-org/gomatrixserverlib#410 still applies too BTW.

@kegsay kegsay merged commit 3197b09 into main Aug 13, 2025
33 of 35 checks passed
@kegsay kegsay deleted the kegan/v0.15.1 branch August 13, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants