Skip to content

Conversation

@codebytere
Copy link
Member

Description of Change

This no longer became necessary after Node.js refactored a bit in nodejs/node#42657 - tests pass without changes now.

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/none target/34-x-y PR should also be added to the "34-x-y" branch. target/35-x-y PR should also be added to the "35-x-y" branch. labels Jan 31, 2025
@codebytere codebytere requested a review from a team as a code owner January 31, 2025 08:40
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@codebytere codebytere changed the title build: remove outdates Node.js serdes patch build: remove outdated Node.js serdes patch Feb 3, 2025
@codebytere
Copy link
Member Author

Unrelated failure:

not ok 1414 chromium features navigator.keyboard should lock the keyboard
  Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/electron/electron/src/electron/spec/chromium-spec.ts)
  Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/electron/electron/src/electron/spec/chromium-spec.ts)
      at listOnTimeout (node:internal/timers:594:17)
      at processTimers (node:internal/timers:529:7)

@codebytere codebytere merged commit 9971087 into main Feb 3, 2025
62 of 63 checks passed
@codebytere codebytere deleted the remove-serdes-patch branch February 3, 2025 13:09
@release-clerk
Copy link

release-clerk bot commented Feb 3, 2025

No Release Notes

@trop
Copy link
Contributor

trop bot commented Feb 3, 2025

I was unable to backport this PR to "34-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/34-x-y PR should also be added to the "34-x-y" branch. label Feb 3, 2025
@trop
Copy link
Contributor

trop bot commented Feb 3, 2025

I was unable to backport this PR to "35-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/34-x-y needs-manual-bp/35-x-y and removed target/35-x-y PR should also be added to the "35-x-y" branch. labels Feb 3, 2025
@trop
Copy link
Contributor

trop bot commented Feb 3, 2025

@codebytere has manually backported this PR to "35-x-y", please check out #45430

@trop
Copy link
Contributor

trop bot commented Feb 3, 2025

@codebytere has manually backported this PR to "34-x-y", please check out #45431

@trop trop bot added in-flight/34-x-y merged/35-x-y PR was merged to the "35-x-y" branch. and removed in-flight/35-x-y labels Feb 3, 2025
codebytere added a commit that referenced this pull request Feb 4, 2025
build: remove outdates Node.js serdes patch
@trop trop bot added merged/34-x-y PR was merged to the "34-x-y" branch. and removed in-flight/34-x-y labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged/34-x-y PR was merged to the "34-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. semver/none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants