Fix a query string parsing problem happend to PDF Viewer #10008
Conversation
|
Would it be possible to add a new spec for this as well? |
There was a problem hiding this comment.
Requires a few minor fixes, LGTM otherwise. Thanks @qazbnm456 !
| // The URL passes the original pdf resource url, that will be requested | ||
| // by the webui page. | ||
| // chrome://pdf-viewer/index.html?src=https://somepage/123.pdf | ||
| GURL escaped_url(net::EscapeUrlEncodedData(original_url.spec(), true)); |
There was a problem hiding this comment.
-
Result of
net::EscapeUrlEncodedDatacan be used directly in the final url creation below,escaped_urlGURLis not required. -
the
use_plusparameter should be invoked with false, since we usenet::UnescapeRule::SPACESbelow.
| base::SplitStringIntoKeyValuePairs(url.query(), '=', '&', &toplevel_params); | ||
| std::string stream_id, src; | ||
|
|
||
| const net::UnescapeRule::Type unescape_rules = |
There was a problem hiding this comment.
SPOOFING_AND_CONTROL_CHARS should be avoided. Also NORMAL rule need not be specified, any rule specified includes the normal rule by default.
|
@kevinsawicki I'll see if I can figure out a way to add a new spec for this! |
|
@kevinsawicki A new spec has been added, and all checks have been passed as well. 😃 |
👍 Thanks for fixing this 🚢 |
3 participants
This PR should resolve #10007.