fix: Detected circular dependencies and add debug logs for nodeModulesCollector #8864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6055b5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmaietta
requested changes
Feb 13, 2025
packages/app-builder-lib/src/node-module-collector/yarnNodeModulesCollector.ts
Outdated
Show resolved
Hide resolved
mmaietta
reviewed
Feb 13, 2025
beyondkmp
changed the title
mmaietta
reviewed
Feb 13, 2025
packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
Outdated
Show resolved
Hide resolved
mmaietta
reviewed
Feb 13, 2025
mmaietta
approved these changes
Feb 14, 2025
This was referenced Feb 14, 2025
Merged
beyondkmp
added a commit
to beyondkmp/electron-builder
that referenced
this pull request
Apr 10, 2025
fix electron-userland#9000 and electron-userland#9006 **Root Cause** It directly copies `node_modules` into the app directory and removes `devDependencies` from `package.json`. This way, `npm list` can retrieve all dependencies. However, during the lookup process, if there are duplicate dependency packages, some `dependencies` in `npm` may be empty. A previous fix（electron-userland#8864 ） introduced the concept of `implicit dependencies` to address this issue, but it only handled the first level of `implicit dependencies`. If `implicit dependencies` themselves contain further `implicit dependencies`, the problem described in electron-userland#9000 will occur. **How to fix** The current approach directly searches the `parsedTree` and updates the global `this.productionGraph`. If there are cases where `dependencies` are empty, it retrieves the same dependency from `allDependencies` and performs a lookup for sub-dependencies. If the dependency already exists in `this.productionGraph`, no further lookup is performed. Additionally, to prevent infinite loops, an empty array is set before searching for sub-dependencies. Now that two tree lookup has been eliminated, there will be a certain improvement in performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8857
Root cause
It's caused by #8851
How to fix
In situations like issue #8851, a
skipCircularDepsparameter should be added. This way, when traversing the tree, only the values inside are retrieved without further traversal, thus avoiding an infinite loop.