Added option for smoother bitcrushing in Decimator #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 15, 2023 21:00
Added boolean option SetSmoothCrushing() to Decimator effect. When it is enabled and bitcrushing amount is set with SetBitcrushFactor(), the bitcrushing effect doesn't jump discretely between bits, but is smoother, or has "fractional bits". When exact number of bits to crush is set with SetBitsToCrush(), smooth crushing is disabled automatically.
Collaborator
|
Hi @Krakenpine. This looks great! Sorry for the delay in jumping on it. Everything looks good, and I should be able to give it a quick test sometime today. |
Collaborator
|
Thanks again for the PR! Finally getting around to merging it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added boolean option SetSmoothCrushing() to Decimator effect.
When it is enabled and bitcrushing amount is set with SetBitcrushFactor(), the bitcrushing effect doesn't jump discretely between bits, but is smoother, or has "fractional bits". When exact number of bits to crush is set with SetBitsToCrush(), smooth crushing is disabled automatically.