Fixes issue of connection string errors not returned properly to the caller #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akalanka47000
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where connection string validation errors were not being properly returned to callers. The fix modifies the URI validation approach in the Connect function by explicitly calling Validate() on the client options after applying the URI, and changes the connection string parsing logic.
Key Changes:
- Modified URI handling to prioritize URI from
ClientOptionsover theConnectionOptions.URIfield - Added explicit validation call using
clientOpts.ApplyURI(opts.URI).Validate()wrapped inlo.Must0 - Changed from
connstring.ParseAndValidatetoconnstring.Parsewith error handling modification
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.