Avoid blocking can_match phase on FrozenEngine #69379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>bug
:Distributed Indexing/Engine
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywelsch
added a commit
that referenced
this pull request
Mar 17, 2021
The backport of #69379 forgot to reenable the tests.
ywelsch
added a commit
that referenced
this pull request
Mar 17, 2021
The backport of #69379 forgot to reenable the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating the FrozenEngine with searchable snapshots found an interesting (existing) bug in FrozenEngine, namely that when the Lucene index was being loaded as part of a query phase, another search in the can_match phase would be blocked, as loading the index is done under a mutex that is also acquired during the can_match phase.
This led to the SearchableSnapshotsIntegTests being very slow, and failing an assertBusy due to the slowness, see https://gradle-enterprise.elastic.co/s/b4w4w7hplq6lc/tests/:x-pack:plugin:searchable-snapshots:internalClusterTest/org.elasticsearch.xpack.searchablesnapshots.SearchableSnapshotsIntegTests/testCreateAndRestorePartialSearchableSnapshot
Closes #69336