[Transform] Ensure transform updates only modify the expected transform task #102934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @przemekwitek, I've created a changelog YAML for you. |
droberts195
reviewed
Dec 4, 2023
droberts195
reviewed
Dec 4, 2023
.../core/src/main/java/org/elasticsearch/xpack/core/transform/action/UpdateTransformAction.java
Show resolved
Hide resolved
|
As this is a very nasty bug I think the fix should be backported to the 8.11 and 7.17 branches. |
przemekwitek
changed the title
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Dec 4, 2023
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Dec 4, 2023
…rm task (elastic#102934) (cherry picked from commit 67ab4b4) # Conflicts: # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/transform/action/UpdateTransformActionRequestTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransportUpdateTransformActionis aTransportTasksActionwhich means that it fans out to individual tasks running on the nodes.In order to find the appropriate tasks the
matchmethod must be implemented properly. For the_updateaction request thematchimplementation was missing which caused the action to fan out to all the transform persistent tasks causing unexpected changes in live (held in memory) transform settings.This PR implements the
matchmethod so that the problem is fixed.Closes #102933