Add repository field to Cargo.toml #11
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am also looking at our dependencies now and out of 569 dependencies only 14 don't have "repository" set. I am trying to ensure that crates are reproducible from the original repos, but already found that some crates have been published from dirty working directories. Good thing is that if packages are built from clean tree, crates built with You might be interested in some previous research on the state of crates.io: https://codeandbitters.com/published-crate-analysis/ |
This was referenced Mar 31, 2024
|
LGTM, thank you! |
|
Could you release a new version to crates.io? |
|
@paolobarbolini Should be done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
repositoryfield to Cargo.toml, making it easier for crates.io users to find the repository hosting the crate's source code. This issue was found by scraping our indirect dependencies from crates.io and verifying that they meet certain criteria. Could a new patch release be made after this PR is merged?Closes #5
Closes #9