feat(client,rpc)!: support auth in wasm rpc client #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
force-pushed
the
feat/jrpc-wasm
branch
3 times, most recently
from
3069cea to
443810e
Compare
zvolin
force-pushed
the
feat/jrpc-wasm
branch
from
443810e to
5140639
Compare
zvolin
changed the title
zvolin
force-pushed
the
feat/jrpc-wasm
branch
from
8eed0c3 to
7b58c33
Compare
zvolin
changed the title
fl0rek
reviewed
Nov 5, 2025
fl0rek
reviewed
Nov 14, 2025
fl0rek
reviewed
Nov 14, 2025
fl0rek
reviewed
Nov 14, 2025
fl0rek
approved these changes
Nov 14, 2025
Member
fl0rek
left a comment
fl0rek
left a comment
There was a problem hiding this comment.
The emulated subscription loop part was rubbing me a wrong way, touch annoying we cannot just return Err(..) there. Left best proposition I could come up with, leaving it to your judgement
Other than that, LGTM!
fl0rek
reviewed
Nov 14, 2025
Co-authored-by: Mikołaj Florkiewicz <[email protected]> Signed-off-by: Maciej Zwoliński <[email protected]>
oblique
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.