Skip to content

Conversation

@jan-pesta
Copy link

No description provided.

@akurtakov
Copy link
Member

This PR looks totally wrong. Please submit only what you have changed/added.

@jan-pesta jan-pesta force-pushed the issue_5047_reproducer branch from af3efb9 to fe1a224 Compare June 10, 2025 06:39
@jan-pesta
Copy link
Author

I just reworked it

@jan-pesta
Copy link
Author

those test failures indikates the issue with versioning. What next is needed here ?

@laeubi
Copy link
Member

laeubi commented Jun 16, 2025

those test failures indikates the issue with versioning

Thanks for the testcase!

What next is needed here ?

Someone needs time to pick this up and provide a fix for it.

@github-actions
Copy link

Test Results

1 011 files  +3  1 011 suites  +3   5h 18m 31s ⏱️ + 14m 11s
1 293 tests +1  1 272 ✅ ±0  20 💤 ±0  1 ❌ +1 
3 879 runs  +3  3 812 ✅ ±0  64 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit fe1a224. ± Comparison against base commit 7a623cc.

@jan-pesta
Copy link
Author

I can create fix for it.
I would like to open discussion because this code has been added with #611.
I am not aware why this part of code has been added, because I did not find a reason for such behavior.

I can imagine to keep it backward compatible to restrict fix only if new configuration is specified. e.q.

    @Parameter(name = "stripQualifierIfDuplicates", defaultValue = "true", property = "tycho.buildqualifier.stripduplicatedqualifier")
    protected Boolean stripQualifierIfDuplicates;

@laeubi
Copy link
Member

laeubi commented Jun 16, 2025

My recommendation would be to add a proposed fix to this PR and then we will see if anything fails and then one might understand it better or even notice that it was unnecessary or ... as we currently preparing a new major release also no immediate need for staying backward compatible.

@jan-pesta jan-pesta force-pushed the issue_5047_reproducer branch from f9f4ca1 to b680fc6 Compare June 16, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants