Clean up codebase with regards to deprecated API #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
approved these changes
May 26, 2023
Ensure that deprecated Action & SModel API is encapsulated and do not leak into non-deprecated API by - Migrating the examples to the new Action/SModel API - Migrating the test cases to the new Action/SModel API - Remove any remaining usage of deprecated Action/SModel API in the non-deprecated code base In addition, this change restructures all files that contain deprecated Action/SModel API and moves the deprecated definitions in a separate section on the end of the file. This enables easy removal of the deprecated API with the 1.0.0 release. The deprecation section at the file end can be safely removed without breaking codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that deprecated Action & SModel API is encapsulated and do not leak into non-deprecated API by
In addition, this change restructures all files that contain deprecated Action/SModel API and moves the deprecated definitions in a separate section on the end of the file.
This enables easy removal of the deprecated API with the 1.0.0 release. The deprecation section at the file end can be safely removed without breaking codebase.