Skip to content

Improve extensibility of multi-injected keys #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

tortmayr
Copy link
Contributor

Double check the codebase and ensure that all all multi-injected classes are bound to self() in Singleton scope before binding them to the multi injection key
Fixes #239

Double check the codebase and ensure that all all multi-injected classes are bound to self() in Singleton scope before binding them to the multi injection key
Fixes #239
Copy link
Contributor

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea. We were concentrated on mouse and key listener, but all multibindings should be handled this way in my opinion.
Thanks!

@tortmayr tortmayr merged commit dacb1e2 into master Mar 17, 2023
@spoenemann spoenemann deleted the issues/#239 branch March 21, 2023 14:34
@spoenemann spoenemann added this to the v0.14.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve extensibility of multi-injected keys
3 participants