feat: JavaExecGenerator uses jkube/jkube-java-binary-s2i for Docker and S2I builds #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=========================================
Coverage 26.27% 26.28%
Complexity 1589 1589
=========================================
Files 350 350
Lines 18296 18295 -1
Branches 2808 2806 -2
=========================================
+ Hits 4807 4808 +1
+ Misses 12931 12929 -2
Partials 558 558
Continue to review full report at Codecov.
|
manusa
force-pushed
the
spike/custom-java-images
branch
from
7825a56 to
a992493
Compare
rohanKanojia
approved these changes
May 20, 2020
…nd S2I builds. - Provided example for spring-boot k8s:watch goal Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
spike/custom-java-images
branch
from
a992493 to
42354d9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
rohanKanojia
approved these changes
May 21, 2020
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes spike PoC in #203 where standard base images are used.
Replace base images used in
JavaExecGenerator(#183) for partially customized images based on JBoss CEKit modules.Images are maintained by us in https://github.com/jkubeio/jkube-images and deployed to our public Quay.io repositories, in this case https://quay.io/repository/jkube/jkube-java-binary-s2i.
These images shouldn't be used outside of Eclipse JKube as we don't want to provide extra-support or maintenance other than that related to the images working with JKube.