Skip to content

Remove storageClass related fields from VolumePermissionEnricher #1989

@rohanKanojia

Description

@rohanKanojia

Component

JKube Kit

Task description

Description

Related to #1179 #1928

🚧 Requires #1928 to get merged and released so that we can remove deprecated fields in this release 🚧

VolumePermissionEnricher seems to be doing more than just changing permission of mounted volume. It also seems to be setting storageClass in PVC.

We moved storageClass related logic in #1928 into PersistentVolumeClaimStorageClassEnricher. However, there are these configuration fields still present in VolumePermissionEnricher:

https://github.com/eclipse/jkube/blob/751a8aacd83de57cf05256a0c7e493926a752652/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/VolumePermissionEnricher.java#L63-L64

They've been marked as @Deprecated for now but we need to remove this in future.

This is just a reminder task to remove these configuration fields and related methods from VolumePermissionEnricher in future.

Expected Behavior

VolumePermissionEnricher shouldn't have any configuration fields related to storageClass

Acceptance Criteria

  • defaultStorageClass and useStorageClassAnnotation have been removed from VolumePermissionEnricher.Config

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions