add missing "authorization" header to make sure it is not written to external headers #2278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thjaeckle
commented
Nov 21, 2025
thjaeckle
commented
- making sure that it is not writen to external headers to not unintentionally leak authorization information (bearer token or basic auth)
There was a problem hiding this comment.
Pull Request Overview
This PR adds security protection by ensuring the "authorization" header is not written to external headers, preventing unintentional leakage of sensitive authentication information like bearer tokens or basic auth credentials.
- Introduces the
AUTHORIZATIONheader definition with internal-only scope - Updates test coverage to verify authorization header handling across multiple test scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DittoHeaderDefinition.java | Adds the AUTHORIZATION header definition configured to prevent external exposure |
| ImmutableDittoHeadersTest.java | Adds test coverage for the new AUTHORIZATION header across existing test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
base/model/src/main/java/org/eclipse/ditto/base/model/headers/DittoHeaderDefinition.java
Outdated
Show resolved
Hide resolved
alstanchev
approved these changes
Nov 21, 2025
…external headers * making sure that it is not writen to external headers to not unintentionally leak authorization information (bearer token or basic auth)
thjaeckle
force-pushed
the
add-missing-authorization-header
branch
from
b357dec to
65e831c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.