Only import the terminal.control #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terminal control is migrated to the Eclipse platform, as those it should be handled like a thrid-party dependency an not directly included with an exact version in the feature. This now changes it to a requirement with a lower bound of 5.5 excluding the next major version. That way CDT and other consumers can gracefully upgrade to the new platform variant.
laeubi
force-pushed
the
remove_from_feature
branch
from
2b7d23e to
166cedc
Compare
|
@jonahgraham can you review/merge? |
|
I don’t have a strong opinion. Though, as you suggest, the import is not necessary. This change will result in that bundle not being in the update site I believe. It is in the Platform’s update site so will be available for simrel aggregation. |
jonahgraham
approved these changes
May 14, 2025
jonahgraham
added
the
noteworthy
|
I will be removing the source from CDT too for this bundle. |
See #1166 |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terminal control is migrated to the Eclipse platform, as those it should be handled like a thrid-party dependency an not directly included with an exact version in the feature.
This now changes it to a requirement with a lower bound of 5.5 excluding the next major version. That way CDT and other consumers can gracefully upgrade to the new platform variant.
In general I think one would not need the feature at all today, as dependencies will be pulled in anyways if installing any of the other ones, but removing it is currently a bit out of scope, so this seems the most compatible way.
FYI @merks