Skip to content

[#305] limit TU children/symbols to be added #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2024
Merged

[#305] limit TU children/symbols to be added #324

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffc1b22
[#305] limit TU children/symbols to be added
ghentschke May 25, 2024
f954156
[#305] use fixed limit for initial children of a TU
ghentschke May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ...clipse.cdt.lsp/src/org/eclipse/cdt/lsp/internal/ui/navigator/CSymbolsContentProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

package org.eclipse.cdt.lsp.internal.ui.navigator;

import java.util.Arrays;
import java.util.Set;

import org.eclipse.cdt.core.model.ITranslationUnit;
Expand All @@ -23,6 +24,8 @@
import org.eclipse.jface.viewers.Viewer;
import org.eclipse.lsp4e.outline.SymbolsModel.DocumentSymbolWithURI;
import org.eclipse.swt.widgets.Control;
import org.eclipse.ui.IWorkbenchPreferenceConstants;
import org.eclipse.ui.internal.WorkbenchPlugin;
import org.eclipse.ui.model.WorkbenchAdapter;
import org.eclipse.ui.progress.DeferredTreeContentManager;
import org.eclipse.ui.progress.IDeferredWorkbenchAdapter;
Expand Down Expand Up @@ -154,13 +157,26 @@ protected void addChildren(Object parent, Object[] children, IProgressMonitor mo
if (children.length != 1 || children[0] != ERROR_ELEMENT) {
viewer.remove(ERROR_ELEMENT);
}
viewer.add(parent, children);
var limitedChildren = children;
var viewLimit = getViewLimit();
if (children.length > viewLimit && viewLimit > 0) {
// limit children to prevent long UI freezes...
// more children can be shown in navigator Treeview via 'Show next x items from remaining y'
// at the end of the list
limitedChildren = Arrays.copyOfRange(children, 0, viewLimit);
}
viewer.add(parent, limitedChildren);
} finally {
control.setRedraw(true);
}
}
});
}

private static int getViewLimit() {
return WorkbenchPlugin.getDefault().getPreferenceStore()
.getInt(IWorkbenchPreferenceConstants.LARGE_VIEW_LIMIT);
}
}

}