Skip to content

fix: add visibleWhen to find references menu entry #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ghentschke
Copy link
Contributor

otherwise to 'Find Refernces' entries were made in the generic editor context menu.

otherwise to 'Find Refernces' entries were made in the generic editor
context menu.
@ghentschke ghentschke requested a review from ruspl-afed March 5, 2024 16:19
@ghentschke
Copy link
Contributor Author

ghentschke commented Mar 5, 2024

@ruspl-afed you were right: a visibleWhen entry is needed. Otherwise two Find References entries are made in the context menu.

@ruspl-afed
Copy link
Member

@ruspl-afed you were right: a visibleWhen entry is needed. Otherwise two Find References entries are made in the context menu.

Thank you for taking my concerns into account, I'm not always wrong :)

Copy link
Member

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghentschke ghentschke merged commit 85ee869 into eclipse-cdt:master Mar 5, 2024
@ghentschke ghentschke deleted the fix-double-find-references branch March 7, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants