Skip to content

Conversation

jonahgraham
Copy link
Member

@jonahgraham jonahgraham commented Feb 28, 2024

The recent change in #271 started needing a newer version of Maven. CDT already had that change made in so I make the same change here.

With eclipse-cdt/.eclipsefdn#7 we can push to origin directly, letting the branch be tested with Jenkins before being merged. So this change is running as https://ci.eclipse.org/cdt/job/cdt-lsp/job/jonah%252Ffix-jenkins-build2/ right now.

@jonahgraham
Copy link
Member Author

Branches pushed to origin will be built and show up in the checks:

image

Non-committers do not have this option though.

@jonahgraham
Copy link
Member Author

This is ready to go @ghentschke - just wanted a second pair of eyes before submitting. Part of the synchronization allows us to add PGP signing which is important if/when we add new third-party content.

@ghentschke
Copy link
Contributor

@jonahgraham Thank you!

@jonahgraham jonahgraham merged commit 1ef344a into master Feb 28, 2024
@jonahgraham jonahgraham deleted the jonah/fix-jenkins-build2 branch February 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants