Add spelling support #244
Merged
Add spelling support #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add reconciler strategy fixes eclipse-cdt#222
- rename reconciler strategy fixes eclipse-cdt#222
- cleanup CSpellingReconcileStrategy fixes eclipse-cdt#222
- add enabler fixes eclipse-cdt#222
ruspl-afed
reviewed
Feb 5, 2024
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/CSpellingReconcileStrategy.java
Outdated
Show resolved
Hide resolved
- use Reconciler extension to get the ISourceViewer needed to instantiate SpellingReconcileStrategy. fixes eclipse-cdt#222
- check for document == null to prevent NPE fixes eclipse-cdt#222
- fix non working spell check in a open document after set 'Enable spell checking' in the Text Editors preference page. fixes eclipse-cdt#222
ghentschke
commented
Feb 14, 2024
| import org.eclipse.jface.text.reconciler.Reconciler; | ||
| import org.eclipse.jface.text.source.ISourceViewer; | ||
|
|
||
| public class CSpellingReconciler extends Reconciler { |
There was a problem hiding this comment.
make it final and in internal package
ghentschke
commented
Feb 14, 2024
| if (editorInput instanceof IFileEditorInput fileEditorInput) { | ||
| return fileEditorInput.getFile(); | ||
| } | ||
| return null; |
ruspl-afed
reviewed
Feb 14, 2024
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/CSpellingReconciler.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/CSpellingReconciler.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/CSpellingReconciler.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/SpellingEnabled.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/SpellingEnabled.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/SpellingEnabled.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/SpellingEnabled.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/SpellingEnabled.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/SpellingEnabled.java
Outdated
Show resolved
Hide resolved
- cleanup code after review fixes eclipse-cdt#222
- add link to spelling preferences page in Editor (LSP) page. fixes eclipse-cdt#222
ruspl-afed
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Thank you for your work @ghentschke !
I have only minor comment regarding newly added UI part, but it may be considered later
bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/EditorConfigurationPage.java
Outdated
Show resolved
Hide resolved
- remove obsolete bracket fixes eclipse-cdt#222
|
@ruspl-afed Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic spelling support in new LSP based C/C++ Editor.
fixes #222