[#83] Rework access to preferences #83 #117
Conversation
ruspl-afed
commented
Jun 11, 2023
ruspl-afed
commented
- Support unified way to work with both project and workspace preferences
- Provide UI to configure preferences in details
Support unified way to work with both project and worksapce preferences Provide UI to configure preferences in details Signed-off-by: Alexander Fedorov <[email protected]>
...se.cdt.lsp.clangd/OSGI-INF/org.eclipse.cdt.lsp.internal.clangd.ClangdConfigurationAccess.xml
Show resolved
Hide resolved
...ipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdPreferenceInitializer.java
Show resolved
Hide resolved
...pse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdLanguageServerProvider.java
Show resolved
Hide resolved
...se.cdt.lsp.clangd/OSGI-INF/org.eclipse.cdt.lsp.internal.clangd.ClangdConfigurationAccess.xml
Show resolved
Hide resolved
...angd/src/org/eclipse/cdt/lsp/internal/clangd/editor/preferences/LspEditorPreferencePage.java
Show resolved
Hide resolved
|
|
||
| public class LspEditorPropertiesPage extends PropertyPage { | ||
| public final class LspEditorPropertiesPage extends PropertyPage { |
There was a problem hiding this comment.
Should be disabled or better hidden, when other ls provider is used.
There was a problem hiding this comment.
Good point, but currently we have nothing to distinguish one provider from another. Could be a a part of #81
| load(); | ||
| composite.setLayout(GridLayoutFactory.fillDefaults().numColumns(3).create()); | ||
| composite.setLayoutData(GridDataFactory.fillDefaults().grab(true, false).create()); | ||
| area = new ClangdConfigurationArea(composite, configuration.metadata()); |
There was a problem hiding this comment.
All settings on project level make only sense, when we support one LS instance per project.
There was a problem hiding this comment.
TBH, I forgot what is blocking us from having LS instance per project. Is this still a limitation of LSP4E?
There was a problem hiding this comment.
Yes. There are two issues: To enable a single LS the boolean singleton element in the org.eclipse.lsp4e.languageServer extension point definition has to be set. To make this configurable, we could define a another language server which is a non-singleton. This solution needs an enable method for the ls definition, which is currently not implemented in the org.eclipse.lsp4e.languageServer extension point, to distinguish between our singleton or non-singleton server.
Another approach would be to make the singleton attribute settable via the org.eclipse.lsp4e.server.StreamConnectionProvider or org.eclipse.lsp4j.services.LanguageServer interface. This is preferred by me.
The other issue is the handling of external files. Which LS should be used for them? In most cases they have been opened by a project file via hyperlink. Here we have to track the origin file for each external file.
|
Thank you for review @ghentschke ! |
