Over locking resources by using WorkbenchJob

[jonahgraham]

See comments by @iloveeclipse on comment: ccf1be4#r153083202 that I have tried to reproduce here

Is there any reason why the code starts a Workbench job to do a resource only operation in UI thread, locking both UI and workspace at same time?
Was it meant to be a WorkspaceJob???

cdt-lsp/bundles/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/clangd/internal/config/ClangFormatFileHandler.java

Line 68 in ccf1be4

WorkbenchJob job = new WorkbenchJob("Create " + ClangFormatFileMonitor.CLANG_FORMAT_FILE + " file") { //$NON-NLS-1$ //$NON-NLS-2$

This operation should better be done in the UI thread via Display.asyncExec(), but this is not the reason to run the whole job in UI thread.

cdt-lsp/bundles/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/clangd/internal/config/ClangFormatFileHandler.java

Line 77 in ccf1be4

openClangFormatFile(formatFileInProject.getLocationURI());

cc: @travkin79 @ghentschke